feat: allow passing app id + api key directly #23
+408
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kombucha
force-pushed
the
feat-credentials-from-opts
branch
4 times, most recently
from
bd6f759 to
dbe0ff6
Compare
kombucha
force-pushed
the
feat-credentials-from-opts
branch
4 times, most recently
from
408a529 to
739a843
Compare
kombucha
force-pushed
the
feat-credentials-from-opts
branch
from
739a843 to
7b708e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What
🤷 Why
It can be practical (for hosting the mcp server) to scope the MCP tools to a specific application instead of relying on the oauth behaviour.
This also allows the node implementation to function in a way that's similar to the Go implementation.
🔍 How
Added an optional
--credentials=applicationId:apiKeycli flags. When present, the MCP server will not use the Dashboard's API tools and endpoint anymore. Instead, the passed credentials will be used directly to query the different public APIs🧪 Testing
Added some ✅